Differential D27377

map ECONNABORTED to ERR_CONNECTION_BROKEN
ClosedPublic
Actions

Authored by sitter on Feb 13 2020, 5:15 PM.

Details

Reviewers
ngraham
Commits
R320:2075e76389cc: smb: map ECONNABORTED to ERR_CONNECTION_BROKEN
Summary

seems the most reasonable candidate given the pretty strings in
KIO::buildErrorString and the detailed causes in the detail function.

this does not really improve the error message, but should dolphin
ever learn to pick up details from detailedErrorStrings it would make
diagnosing easier.

ECONNABORTED can mean any number of things, so I guess a signle line
error will always be incredibly vague.

BUG: 415436
FIXED-IN: 19.12.3

Test Plan

hoping for the best!

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Feb 13 2020, 5:15 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptFeb 13 2020, 5:15 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Feb 13 2020, 5:15 PM
ngraham added a comment.Feb 13 2020, 5:21 PM

I think this is reasonable and at least a small improvement given the limitations at play here.

ngraham accepted this revision.Feb 13 2020, 5:21 PM
This revision is now accepted and ready to land.Feb 13 2020, 5:21 PM
Closed by commit R320:2075e76389cc: smb: map ECONNABORTED to ERR_CONNECTION_BROKEN (authored by sitter). · Explain WhyFeb 14 2020, 4:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msmb/kio_smb_browse.cpp (2 lines)

Diff 75703

View Options

smb/kio_smb_browse.cpp

Loading...