Differential D27392

[Applet]Add info messages.
ClosedPublic
Actions

Authored by gvgeo on Feb 14 2020, 6:53 AM.

Details

Reviewers
jgrulich
ngraham
Group Reviewers
Plasma
VDG
Commits
R116:387609d10ac7: [Applet]Add info messages.
Summary

Add info messages, when there are no available connections.
"Airplane mode is enabled"
"Wireless and mobile networks are deactivated"
"Wireless is deactivated"
"Mobile network is deactivated"
And "No available connections" with 5 seconds delay.

Test Plan

Diff Detail

Repository
R116 Plasma Network Management Applet
Branch
warings (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22472
Build 22490: arc lint + arc unit
gvgeo created this revision.Feb 14 2020, 6:53 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 14 2020, 6:53 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gvgeo requested review of this revision.Feb 14 2020, 6:53 AM
gvgeo edited the test plan for this revision. (Show Details)Feb 14 2020, 6:55 AM
broulik added a subscriber: broulik.Feb 14 2020, 9:07 AM
broulik added inline comments.
applet/contents/ui/Toolbar.qml
32

Make it readonly property bool

gvgeo updated this revision to Diff 75669.Feb 14 2020, 10:07 AM

Made properties readonly.

gvgeo marked an inline comment as done.Feb 14 2020, 10:07 AM
ngraham added a subscriber: ngraham.Feb 14 2020, 3:40 PM

Both labels should have enabled: false set to lighten the text in a consistent way.

gvgeo updated this revision to Diff 75721.Feb 14 2020, 5:25 PM

Set first label enabled false, and the second specified opacity to 0.6 instead (it is used as a delay).

ngraham accepted this revision.Feb 14 2020, 5:32 PM
gvgeo edited the test plan for this revision. (Show Details)Feb 14 2020, 5:35 PM
jgrulich accepted this revision.Feb 17 2020, 2:16 PM
This revision is now accepted and ready to land.Feb 17 2020, 2:16 PM
Closed by commit R116:387609d10ac7: [Applet]Add info messages. (authored by gvgeo, committed by ngraham). · Explain WhyFeb 18 2020, 4:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 75669

View Options

applet/contents/ui/PopupDialog.qml

Loading...
View Options

applet/contents/ui/Toolbar.qml

Loading...