Differential D27294

fix free space calculation
ClosedPublic
Actions

Authored by sitter on Feb 10 2020, 4:26 PM.

Details

Reviewers
ngraham
meven
Commits
R320:6832817f311b: smb: fix free space calculation
Summary
  • collapse statvfs call, there's no purpose in manually opening the file when libsmbc has a convenience wrapper that does exactly what we need with less code on our end
  • blockSize is now calculated as per the conditional branches in smbc_stat.c
  • free space calculation is now backwards compatible with slightly busted legacy versions of libsmbc not setting f_bavail

FIXED-IN: 19.12.3
BUG: 298801

Test Plan

free space calculation now works with windows10, ubuntu18.04, ubuntu19.10

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Feb 10 2020, 4:26 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptFeb 10 2020, 4:26 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Feb 10 2020, 4:26 PM
meven accepted this revision.Feb 11 2020, 8:15 AM
meven added a subscriber: meven.

Tested with success with samba 4.5

I gave a try to fix this issue, did not got through until samba's code. Thanks

This revision is now accepted and ready to land.Feb 11 2020, 8:15 AM
ngraham accepted this revision.Feb 11 2020, 5:50 PM

Nice!

Closed by commit R320:6832817f311b: smb: fix free space calculation (authored by sitter). · Explain WhyFeb 13 2020, 12:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msmb/kio_smb_browse.cpp (37 lines)

Diff 75600

View Options

smb/kio_smb_browse.cpp

Loading...