Details
Details
- Reviewers
davidedmundson broulik - Group Reviewers
Frameworks - Commits
- R274:3dae871e6b89: Fix infinite recursion in xscreensaver plugin
Test plan similar to D27279, but powerdevil should no longer crash
Diff Detail
Diff Detail
- Repository
- R274 KIdleTime
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Neither the XSync nor the windows backend explicitly call resumingFromIdle in simulateUserActivity, so I think this should be fine.
However, I don't know if that won't indirectly trigger it if the session was idle? Maybe we need to check if the session was idle and only then emit the signal.
Comment Actions
I'm not sure how exactly it works, but if session was idle, wouldn't function screensaverActivated be called on changing state? And it contains emit resumingFromIdle():
Comment Actions
Sorry, I just returned from vacation. I'll merge this on Monday (since Frameworks tagging is tomorrow) so we'll get another month worth of testing.