Well yes that extremely ugly and some real refactoring would be needed....
Details
Diff Detail
- Repository
- R289 KNotifications
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 22418 Build 22436: arc lint + arc unit
While preparing this I discovered that we should also review the locations where if MAC is used, as thats not the only platform that should use the systray icon
src/kstatusnotifieritem.cpp | ||
---|---|---|
48 | New header? | |
617 | Won't this mean that showMessage() is a no-op on Windows systems without D-Bus? | |
888 | From my reading of the setLegacySystemTrayEnabled() won't setting it to false explicitly disable any form of system tray icon? |
thank you!
I did the same but way worse.
I think we can at least push this fix to remove all failing jobs then clean it up? This should fix half the failing jobs.
CMakeLists.txt | ||
---|---|---|
94 | this is not the aim of this diff, but I looked at the code, I found this line was duplicated from line 43 |
Can we push it as this to fix the Windows builds? It also breaks a few ones in https://binary-factory.kde.org/view/Windows%2064-bit/