Differential D27348

Port to use level 1 Heading instead of Title
ClosedPublic
Actions

Authored by ngraham on Feb 12 2020, 3:17 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R119:eb91f8e983f2: Port to use level 1 Heading instead of Title
Summary

PlasmaExtras.Title is deprecated and literally identical to a level 1 Heading. Let's port
to that so we have less code to maintain and fewer things to change the next time we
want to adjust the look of titles.

Test Plan

No visual changes

Diff Detail

Repository
R119 Plasma Desktop
Branch
port-to-heading (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22403
Build 22421: arc lint + arc unit
ngraham created this revision.Feb 12 2020, 3:17 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 12 2020, 3:17 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 12 2020, 3:17 PM
ngraham edited the summary of this revision. (Show Details)Feb 12 2020, 3:30 PM
davidedmundson requested changes to this revision.Feb 21 2020, 1:20 PM
davidedmundson added a subscriber: davidedmundson.

PlasmaExtras.Title is deprecated

Docs don't say anything of the sort

This revision now requires changes to proceed.Feb 21 2020, 1:20 PM
ngraham added a comment.Feb 21 2020, 2:06 PM
In D27348#615134, @davidedmundson wrote:

PlasmaExtras.Title is deprecated

Docs don't say anything of the sort

I found a deprecation message in the component itself: https://cgit.kde.org/plasma-framework.git/tree/src/declarativeimports/plasmaextracomponents/qml/Title.qml#n42

davidedmundson accepted this revision.Feb 21 2020, 3:09 PM

I stand corrected, my apologies.

This revision is now accepted and ready to land.Feb 21 2020, 3:09 PM
ngraham added a comment.Feb 21 2020, 3:10 PM

No worries. :) How about D27350 too?

Closed by commit R119:eb91f8e983f2: Port to use level 1 Heading instead of Title (authored by ngraham). · Explain WhyFeb 21 2020, 3:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 75553

View Options

desktoppackage/contents/activitymanager/Heading.qml

Loading...
View Options

desktoppackage/contents/explorer/WidgetExplorer.qml

Loading...