Differential D27290

Update obsolete QWidget::getContentsMargins
ClosedPublic
Actions

Authored by gengisdave on Feb 10 2020, 3:19 PM.

Details

Reviewers
asensi
Group Reviewers
Krusader
Commits
R167:8ddc89784725: Replace obsolete QWidget::getContentsMargins
Summary

In Qt 5.14, QWidget::getContentsMargins(int, int, int, int) is deprecated in favor of QWidget::contentsMargins().

QWidget::contentsMargins() was introduced in Qt 4.6, no #if guards are needed

Test Plan

Compile and test. The changes impact on MountMan GUI.

Diff Detail

Repository
R167 Krusader
Lint
Lint Skipped
Unit
Unit Tests Skipped
gengisdave requested review of this revision.Feb 10 2020, 3:19 PM
gengisdave created this revision.
asensi accepted this revision as: asensi.Feb 19 2020, 10:29 PM
asensi added a subscriber: asensi.

I've been using daily those changes for more than a week and everything looked alright. Other people can do their checks. Thanks, Davide!

This revision is now accepted and ready to land.Feb 19 2020, 10:29 PM
Closed by commit R167:8ddc89784725: Replace obsolete QWidget::getContentsMargins (authored by gengisdave). · Explain WhyMar 3 2020, 7:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 75378

View Options

krusader/Dialogs/krspecialwidgets.cpp

Loading...