paint together the cursor image and the extra dnd image if available
on X11 with QDrag::setHotspot is possible to control their relative
position, which doesn't seem to have a wayland protocol correspondence
so their relative position are controlled just by the hotspot of the cursor itself
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma KWin - Commits
- R108:baebfb7f7e0b: actually draw drag icons in the mouse cursor during drags
folder graphics from dolphin is painted correctly
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
which doesn't seem to have a wayland protocol correspondence
It does.
A drag has a surface
A surface has a buffer
A buffer has an offset (or hotspot) to the surface
Qt does set this:
qwaylanddnd.cpp:70
pointer_input.cpp | ||
---|---|---|
1262 | I don't think this is needed given we are copying (implicitly) via the painting into another surface we can just p.drawImage(p_.data()); |
pointer_input.cpp | ||
---|---|---|
1222 | i.e the hotspot should be daragIcon->offset(); from here. |