Differential D27138

[Applet] Display device name when there is than one device
ClosedPublic
Actions

Authored by gvgeo on Feb 3 2020, 6:33 PM.

Details

Reviewers
drosca
ngraham
Group Reviewers
Plasma
VDG
Commits
R115:1b737cfe6613: [Applet] Display device name when there is than one device
Summary

Display both device name and port if there is more than one device.
Applies separately for playback and recording devices.

BUG: 417079

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Branch
devicesCount (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22067
Build 22085: arc lint + arc unit
gvgeo created this revision.Feb 3 2020, 6:33 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 3 2020, 6:33 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gvgeo requested review of this revision.Feb 3 2020, 6:33 PM
ngraham added a comment.Feb 3 2020, 9:57 PM

Makes 1 check and apply both for playback and recording devices.

Are you sure that makes sense? If I have two outputs but only one input (a common setup) then I don't want my microphone having an unnecessarily long description. Might be nicer to keep the current approach of checking for multiple inputs and outputs separately IMO.

gvgeo added a comment.Feb 4 2020, 2:45 AM
In D27138#605645, @ngraham wrote:

Makes 1 check and apply both for playback and recording devices.

Are you sure that makes sense? If I have two outputs but only one input (a common setup) then I don't want my microphone having an unnecessarily long description. Might be nicer to keep the current approach of checking for multiple inputs and outputs separately IMO.

And maybe wander which device has the mic.
I would love to hear from others, If they have a preference on this. 2 separate checks or 1 ?

I will make the change later.

ngraham added a comment.Feb 4 2020, 8:29 PM

I'm willing to be overruled if everybody else prefers the proposed change. :)

gvgeo updated this revision to Diff 75016.Feb 4 2020, 8:51 PM
gvgeo retitled this revision from [Applet]Restore naming convention for devices. to [Applet]Display device name if more than one devices.
gvgeo edited the summary of this revision. (Show Details)

Separate check

gvgeo added a comment.Feb 5 2020, 12:09 PM

No response, I believe this patch can continue.

ngraham accepted this revision.Feb 6 2020, 2:49 AM

Any objections?

This revision is now accepted and ready to land.Feb 6 2020, 2:49 AM
ngraham edited the summary of this revision. (Show Details)Feb 6 2020, 4:34 PM
ngraham retitled this revision from [Applet]Display device name if more than one devices to [Applet] Display device name when there is than one device.
ndavis added a subscriber: ndavis.Feb 6 2020, 4:36 PM

no objections :)

Closed by commit R115:1b737cfe6613: [Applet] Display device name when there is than one device (authored by gvgeo, committed by ngraham). · Explain WhyFeb 6 2020, 4:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 75016

View Options

applet/contents/ui/DeviceListItem.qml

Loading...
View Options

applet/contents/ui/main.qml

Loading...