Differential D27071

Remove KCM Init Phase 2
ClosedPublic
Actions

Authored by broulik on Jan 31 2020, 3:40 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:68f16bae9bbe: Remove KCM Init Phase 2
Summary

It is unused and we have better means of daemon autostart than this.

Test Plan

Compiles.
I don't think that README in ksmserver is really any good but I updated it regardless.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jan 31 2020, 3:40 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 31 2020, 3:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 31 2020, 3:40 PM
davidedmundson added a subscriber: davidedmundson.Feb 3 2020, 12:11 AM
davidedmundson added inline comments.
startkde/kcminit/main.cpp
133–137

can you add

if (libphase > 1 )
libphase = 1

just in case of some hypothetical 3rd party out there

broulik updated this revision to Diff 74986.Feb 4 2020, 8:53 AM
  • Check phase > 1
davidedmundson accepted this revision.Feb 4 2020, 9:34 AM
This revision is now accepted and ready to land.Feb 4 2020, 9:34 AM
Closed by commit R120:68f16bae9bbe: Remove KCM Init Phase 2 (authored by broulik). · Explain WhyFeb 4 2020, 9:35 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 74986

View Options

ksmserver/README

Loading...
View Options

startkde/kcminit/main.h

Loading...
View Options

startkde/kcminit/main.cpp

Loading...
View Options

startkde/plasma-session/startup.h

Loading...
View Options

startkde/plasma-session/startup.cpp

Loading...