Differential D26951

Remove old code that is not used anymore
ClosedPublic
Actions

Authored by davidre on Jan 27 2020, 5:35 PM.

Details

Reviewers
dfaure
ervin
Group Reviewers
Frameworks
Commits
R265:db859852b577: Remove old code that is not used anymore
Summary

According to the comment it was for Qt3 support which we don't support anymore.

Diff Detail

Repository
R265 KConfigWidgets
Branch
arcpatch-D26951
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21963
Build 21981: arc lint + arc unit
davidre created this revision.Jan 27 2020, 5:35 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 27 2020, 5:35 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidre requested review of this revision.Jan 27 2020, 5:35 PM
davidedmundson added a subscriber: davidedmundson.Jan 27 2020, 5:49 PM

Does it affect:

kwidgetsaddons/src/kselector.h:48

(no idea what that is, just something grep found)

davidre added a comment.Jan 27 2020, 6:44 PM

If it's still something we ship than I think it is better to just change the comment

ervin added a comment.Jan 28 2020, 6:20 PM

LGTM, better wait for @dfaure opinion though

dfaure requested changes to this revision.Feb 2 2020, 10:51 AM

I don't really know KConfigDialogManager. But indeed KSelector has properties with those names so if someone wanted to use e.g. KGradientSelector here it sounds like this would be useful -> just adjust the comment?

This revision now requires changes to proceed.Feb 2 2020, 10:51 AM
davidre updated this revision to Diff 74856.Feb 2 2020, 1:46 PM

Update comment

dfaure accepted this revision.Feb 2 2020, 1:56 PM
This revision is now accepted and ready to land.Feb 2 2020, 1:56 PM
Closed by commit R265:db859852b577: Remove old code that is not used anymore (authored by davidre). · Explain WhyFeb 2 2020, 1:56 PM
This revision was automatically updated to reflect the committed changes.
davidre added a comment.Feb 2 2020, 2:11 PM

I just took a look at KSelector and it actually inherits minimum and maximum properties from QAbstractSlider so we could just drop these custom properties for KF6

Revision Contents
Changeset List

PathPackages
Msrc/kconfigdialogmanager.cpp (4 lines)

Diff 74856

View Options

src/kconfigdialogmanager.cpp

Loading...