Differential D26993

[libkworkspace] Introduce UpdateLaunchEnvJob
ClosedPublic
Actions

Authored by broulik on Jan 29 2020, 3:39 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:6253163af827: [libkworkspace] Introduce UpdateLaunchEnvJob
Summary

This is supposed to replace manual DBus calls to KLauncher setLaunchEnv done in e.g. the KCMs, so this can easily be extended in the future.

Test Plan
  • Successfully changed an env variable

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jan 29 2020, 3:39 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 29 2020, 3:39 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 29 2020, 3:39 PM
davidedmundson added a subscriber: davidedmundson.Jan 29 2020, 4:05 PM

+++

Lets port some usages, so we can confirm it works in practice, but this looks good

libkworkspace/updatelaunchenvjob.cpp
80

Not quite. It's plasma-session

It spawns processes, which in turn might update the launch env, that we should have that env when we spawn the next round of processes.

davidedmundson added inline comments.Jan 30 2020, 10:39 AM
libkworkspace/updatelaunchenvjob.h
29

Docs

davidedmundson accepted this revision.Jan 30 2020, 10:53 AM
This revision is now accepted and ready to land.Jan 30 2020, 10:53 AM
Closed by commit R120:6253163af827: [libkworkspace] Introduce UpdateLaunchEnvJob (authored by broulik). · Explain WhyJan 30 2020, 10:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 74668

View Options

libkworkspace/CMakeLists.txt

Loading...
View Options

libkworkspace/updatelaunchenvjob.h

Loading...
View Options

libkworkspace/updatelaunchenvjob.cpp

Loading...