Differential D27019

Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess
ClosedPublic
Actions

Authored by meven on Jan 30 2020, 9:11 AM.

Details

Reviewers
broulik
ngraham
ervin
Group Reviewers
Plasma
Commits
R119:5eb5c9ab7d7e: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess
Summary

BUG: 396537
FIXED-IN: 5.18

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21833
Build 21851: arc lint + arc unit
meven created this revision.Jan 30 2020, 9:11 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 30 2020, 9:11 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Jan 30 2020, 9:11 AM
meven edited the summary of this revision. (Show Details)Jan 30 2020, 9:11 AM
broulik added a comment.Jan 30 2020, 9:11 AM

Can we do the foreach ports separately, please

meven edited the summary of this revision. (Show Details)Jan 30 2020, 9:14 AM
meven updated this revision to Diff 74649.Jan 30 2020, 9:14 AM

Separate foreach conversions

broulik added inline comments.Jan 30 2020, 9:15 AM
solid-device-automounter/kcm/DeviceModel.cpp
119

Do we want to add items that are *not* a StorageAccess?
Shouldn't this be more like

if (access && !access->isIgnored())`
meven updated this revision to Diff 74654.Jan 30 2020, 9:45 AM
meven marked an inline comment as done.

Only display device that are not ignored Solid::StorageVolume and Solid::StorageAccess

meven updated this revision to Diff 74656.Jan 30 2020, 9:54 AM

Checking if this is a not-ignored or not mounted StorageAccess is what we need

meven added inline comments.Jan 30 2020, 1:16 PM
solid-device-automounter/kcm/DeviceModel.cpp
119

I needed to add the not mounted storage access as storage access ignores not mounted system

meven marked an inline comment as done.Jan 30 2020, 2:42 PM
meven updated this revision to Diff 74767.Jan 31 2020, 12:44 PM

Don't list ignored devices as intended

ervin accepted this revision.Jan 31 2020, 1:42 PM
This revision is now accepted and ready to land.Jan 31 2020, 1:42 PM
Closed by commit R119:5eb5c9ab7d7e: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess (authored by meven). · Explain WhyFeb 3 2020, 7:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 74654

View Options

solid-device-automounter/kcm/DeviceModel.cpp

Loading...