The property currentValue is conflicting making the qml file not run.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma: Workspaces - Commits
- R120:ce69fc4ea914: Fix systemtray configuration
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- Plasma/5.18
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 21669 Build 21687: arc lint + arc unit
Comment Actions
Thanks for noticing! The currentValue property was introduced with QtQuick.Controls 2.14 (Qt 5.14). Very convenient, unfortunately Plasma 5.18 must support Qt 5.12.
BTW. QML import system is stupid (or I am :) ). Apparently, using import QtQuick.Controls 2.5 will not allow you to use currentValue, but it will still conflict...
applets/systemtray/package/contents/ui/ConfigEntries.qml | ||
---|---|---|
198 | Instead of removing currentValue change it's name. This property is used in KeySequenceItem | |
269 | I won't work in Qt =< 5.13. Just rename currentValue to something not-conflicting. |
Comment Actions
@konrad you're part of the kde team now. Feel free to approve things you're comfortable with.