Resize previews and icons according to the preview widget size
AbandonedPublic

Authored by meven on Jan 24 2020, 7:00 PM.

Details

Reviewers
ngraham
elvisangelaccio
Group Reviewers
Dolphin
Summary

Make the preview high-dpi aware.

BUG: 313050
FIXED-IN: 20.04

Diff Detail

Repository
R318 Dolphin
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21636
Build 21654: arc lint + arc unit
meven created this revision.Jan 24 2020, 7:00 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptJan 24 2020, 7:00 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
meven requested review of this revision.Jan 24 2020, 7:00 PM
meven added a comment.Jan 24 2020, 7:10 PM

Updated compared to D11022

meven updated this revision to Diff 74329.Jan 24 2020, 7:12 PM

Fix unwanted change

I'm still not a big fan of the huge "normal" icon, but at least now they don't look bad as in D11022.

I noticed there is flickering when you switch between a normal folder icon and a previews folder icon, in particular if you expand the information panel. Can you try to fix that?

meven added a comment.EditedJan 26 2020, 11:41 AM

I'm still not a big fan of the huge "normal" icon, but at least now they don't look bad as in D11022.

We could easily keep the preview size under a value, like KIconLoader::SizeEnormous currently, but maybe bigger like 2 * KIconLoader::SizeEnormous.
But I think that letting the user choose for himself the size of the preview, base on the size of the panel, is a nice feature.

I noticed there is flickering when you switch between a normal folder icon and a previews folder icon, in particular if you expand the information panel. Can you try to fix that?

I guess you mean the transition animation between the two preview (icon and preview).
The animation is good eye-candy when switching between two very different previews, from a file preview to a folder preview for instance.
And I would argue that this is valuable when switching between folder preview and folder icon, because it informs the user, the preview has been updated.

meven added a comment.Feb 12 2020, 4:16 PM

ping @elvisangelaccio

Should I split the hidpi fix ?
It is the first and last changes.

Yeah maybe we should split out the high DPI fix and the UI change into separate patches.

meven added a comment.Mar 25 2020, 3:27 PM

It makes me think we should improve PreviewJob to be devicePixelRatio aware, so we can fix the tooltips too.