[Applet/Task Manager] Move audio indicator to the corner
ClosedPublic

Authored by gvgeo on Jan 23 2020, 9:22 AM.

Details

Summary

When vertical or Icon-only task manager, shrink click area 10% and
indicator 30%.
This allows moving it closer to the corner, away from the center,
to avoid accidental audio muting.

BUG: 416553
FIXED-IN: 5.19.0

Test Plan

With patch

Diff Detail

Repository
R119 Plasma Desktop
Branch
pos2 (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21614
Build 21632: arc lint + arc unit
gvgeo created this revision.Jan 23 2020, 9:22 AM
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptJan 23 2020, 9:22 AM
gvgeo requested review of this revision.Jan 23 2020, 9:22 AM
gvgeo edited the test plan for this revision. (Show Details)EditedJan 23 2020, 9:24 AM

Could not pinpoint a specific size to disable mute function. If it is still a problem with this patch, maybe need to disable it for 5.18, and add a config option in the next release.

ngraham accepted this revision.Jan 23 2020, 3:46 PM
ngraham added subscribers: cblack, filipf, ndavis and 2 others.

I was working on a patch to improve things here and it was almost identical to this one. I think this is a good fix. Tested on an IOTM as well as a regular task manager on all four screen edges with various panel thicknesses and I did not find any regressions, and it did seem better to me.

Let's make sure we hear from some of the other people who I recall had voiced concerns about the indicator getting in the way: @Fuchs, @broulik, @cblack, @filipf @ndavis

This revision is now accepted and ready to land.Jan 23 2020, 3:46 PM
ngraham edited the summary of this revision. (Show Details)Jan 23 2020, 3:46 PM

I don't use IOTM, but this looks quite alright to me.

gvgeo planned changes to this revision.Jan 23 2020, 6:48 PM

I also just noticed a pre-existing bug - that the hover effect filling the mouse area doesn't work well when the icon is smaller:

The icon overflows the hover effect. I'm going to have the effect fill the icon instead:

I will rebase on this patch and make icon aware of the orientation.
Otherwise highlight area will overlap with the blue-bar on top when horizontal.

Fuchs added a comment.Jan 23 2020, 6:49 PM

Looks good to me, thank you very much for the work :-)

Sidesnotes that I mentioned in the group, just so they are documented here:

  • I think for a clickable action it can become too small, so it takes too much aiming. However, it doesn't get in the way, and people annoyed by it can just disable it completely, so that's probably fine
  • Icon wise, given that it can still overlap with the app icon, I would prefer something that has a contrasting border, so e.g. a dark audio indicator is still visible on a dark app icon. But that can probably be addressed in a separate task, especially as it also affects other icons we have
  • Icon wise, given that it can still overlap with the app icon, I would prefer something that has a contrasting border, so e.g. a dark audio indicator is still visible on a dark app icon. But that can probably be addressed in a separate task, especially as it also affects other icons we have

Yeah that's planned for 5.19.

gvgeo updated this revision to Diff 74297.Jan 24 2020, 9:21 AM

Increase right margins by 1.2 when need, to avoid highlight area been drawn out of the frame.
Various little changes.

This revision is now accepted and ready to land.Jan 24 2020, 9:21 AM
gvgeo updated this revision to Diff 74298.Jan 24 2020, 9:28 AM

Change line order.

gvgeo added a comment.Jan 24 2020, 9:37 AM

Never going to be correct. Sometimes the highlight touches the edges, other times have big margins. The aim was to avoid getting out of the svg frame.

These changes focus even more on the breeze theme.
Sweet theme has some issues.

ngraham accepted this revision.Jan 24 2020, 4:55 PM

Yeah, it won't be perfect for everything, but I think it's better than what we have right now and fixes the bug.

Is everyone okay with this?

Well I tested this with several themes and it looks just fine on all of them except Sweet. A Plasma person should have a look at the code, but visually and usability-wise this is pretty good.

No response, assuming that means it's good. :)

Landing on master to be safe, but if Plasma people take a look later and like what they see, we can backport this to the stable branch.

ngraham edited the summary of this revision. (Show Details)Feb 12 2020, 7:10 PM
This revision was automatically updated to reflect the committed changes.
gvgeo added a comment.Feb 16 2020, 8:37 AM

before


after