Some Plasma themes used filled-style highlight effects which means that their audio icon gets completely covered by the highlight effect.
This patch makes the effect be drawn behind the icon.
Some Plasma themes used filled-style highlight effects which means that their audio icon gets completely covered by the highlight effect.
This patch makes the effect be drawn behind the icon.
Before:
After:
Before:
After:
No Linters Available |
No Unit Test Coverage |
Buildable 21598 | |
Build 21616: arc lint + arc unit |
More sane value like z: 1 in the svg should be enough .
But in this case can MouseArea move before svg? Makes more sense to me, having the code in the draw order .
I'm not a developer, just asking.
don't use "z" hacks, just rearrange the order of items
also port the top item to MouseArea to be more efficient
Now that you got me thinking, I wonder if the top item can just be switched from Item to MouseArea. Works for me so I updated the diff.
@hein ?
I also just noticed a pre-existing bug - that the hover effect filling the mouse area doesn't work well when the icon is smaller:
The icon overflows the hover effect. I'm going to have the effect fill the icon instead:
have the hover effect fill the icon instead of the mousearea so that the icon doesn't overflow the effect at small sizes
LGTM but let's wait for a Plasma review too to make sure this is the most technically correct way (I think it is but I'm not 100% sure).
I also think this would look more attractive. I've already investigated the possibility and here's a few notes: