| davidedmundson | |
| ngraham |
| Plasma | |
| VDG |
Kickoff's separators were drawn as rectangles which doesn't allow them to be themed.
We have the infrastructure to theme lines though so this patch makes use of it.
The benefit is that themes can now gracefully incorporate separators into their design.
Tested with Oxygen.
Before:
After:
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| applets/kickoff/package/contents/ui/FullRepresentation.qml | ||
|---|---|---|
| 127 | maybe this doesn't need to be specified anymore? (and everywhere else in the diff) | |
When using the Breeze style, the blue selection line no longer touches the separator line:
When using the Breeze style, the blue selection line no longer touches the separator line:
Unfortunately not, yeah. It happens with all themes and is due to the changes in the height/width. The thing is if I leave the old height/width values the lines get rendered more dimly than they should so they need to be using the SVG's element size.
Now as for why this element size generates padding, I'm not sure. I could look into PlasmaCore.Svg and PlasmaCore.SvgItem source files.
Might actually be a lot simpler. It seems our line SVG file adds 1px of padding on each side:
@ndavis do you think it's alright to remove this padding?