Differential D26817

Change docbooks in order to make Krusader build at least under (K)Ubuntu 18.04 LTS and in docs.kde.org
ClosedPublic
Actions

Authored by asensi on Jan 21 2020, 10:20 PM.

Details

Reviewers
yurchor
Group Reviewers
Krusader
Commits
R167:582588663724: Change docbooks in order to make Krusader build at least under (K)Ubuntu 18.04…
Summary

Building Krusader under Kubuntu/Ubuntu 18.04 LTS (and some other distributions) shows some minor errors like:

Note: Writing krusader.1
[100%] Built target doc-krusader-1
[100%] Generating index.cache.bz2
introduction.docbook:96: parser error : Entity 'NFS' not defined
    servers, TAR archives, &NFS; filesystems, SAMBA shares, ISO
                                ^
introduction.docbook:106: parser error : Entity 'NFS' not defined
    (&FTP;, &NFS;, Samba, FISH, SFTP).</para>
                ^
introduction.docbook:152: parser error : chunk is not well balanced

^
index.docbook:347: parser error : Failure to process entity introduction
&introduction;
                ^
index.docbook:347: parser error : Entity 'introduction' not defined
&introduction;
                ^
kf5.kdoctools: Error: `xmllint --noout` outputted text
doc/CMakeFiles/doc-index-cache-bz2.dir/build.make:95: recipe for target 'doc/index.cache.bz2' failed
make[2]: *** [doc/index.cache.bz2] Error 1
CMakeFiles/Makefile2:2263: recipe for target 'doc/CMakeFiles/doc-index-cache-bz2.dir/all' failed
make[1]: *** [doc/CMakeFiles/doc-index-cache-bz2.dir/all] Error 2
        Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2

although that doesn't allow Krusader to be built.

The problem doesn't happen if the proposed patch is applied, although maybe there are better solutions :-?

Diff Detail

Repository
R167 Krusader
Lint
Lint Skipped
Unit
Unit Tests Skipped
asensi created this revision.Jan 21 2020, 10:20 PM
Restricted Application added a project: Documentation. · View Herald TranscriptJan 21 2020, 10:20 PM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
asensi requested review of this revision.Jan 21 2020, 10:20 PM
yurchor added a subscriber: yurchor.Jan 22 2020, 6:38 AM

This can be solved much more easily without breaking translations by adding entities into index.docbook header (~line 27):

<!ENTITY NFS   "<acronym>NFS</acronym>">
<!ENTITY Samba "<application>Samba</application>">

Should I do it by myself?

Thanks in advance for your answers.

asensi updated this revision to Diff 74176.EditedJan 22 2020, 9:41 PM

The changes suggested by Yuri Chornoivan were made, also the USB entity was defined.

yurchor accepted this revision.Jan 23 2020, 6:59 AM
This revision is now accepted and ready to land.Jan 23 2020, 6:59 AM
asensi retitled this revision from Change docbooks in order to make Krusader build at least under Kubuntu/Ubuntu 18.04 LTS to Change docbooks in order to make Krusader build at least under (K)Ubuntu 18.04 LTS and in docs.kde.org.Jan 23 2020, 9:43 PM
Closed by commit R167:582588663724: Change docbooks in order to make Krusader build at least under (K)Ubuntu 18.04… (authored by asensi). · Explain WhyJan 23 2020, 10:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdoc/index.docbook (3 lines)

Diff 74176

View Options

doc/index.docbook

Loading...