- Reset and apply button are not activated anymore if we change twice state of an item going back to the current saved state
- Immutability disable all actions for an entry
- Default is activated if not all mutable entry are set to true
Details
Details
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 21506 Build 21524: arc lint + arc unit
kcms/kded/modulesmodel.cpp | ||
---|---|---|
234 | Inserted twice, line 219 |
kcms/kded/modulesmodel.cpp | ||
---|---|---|
234 | Yes I insert it twice first one is for autoenable value (that will change when we check or uncheck entry), and the second one is the base value to know if data are dirty or not. |
Comment Actions
Not a fan of the AutoloadEnabledSavedRole in the model
kcms/kded/kcmkded.cpp | ||
---|---|---|
268 | I think instead you could have the model refuse to setData when immutable | |
kcms/kded/modulesmodel.cpp | ||
126–127 | Since generally setData only does things for AutostartType, perhaps move that check out of the switch | |
225 | Superfluous space | |
265 | Check whether it actually changed before emitting it |