Port KReportDocument to use a d-pointer
ClosedPublic

Authored by piggz on Oct 12 2016, 9:56 PM.

Diff Detail

Repository
R14 KReport
Branch
d_ptr
Lint
No Linters Available
Unit
No Unit Test Coverage
piggz updated this revision to Diff 7364.Oct 12 2016, 9:56 PM
piggz retitled this revision from to Port KReportDocument to use a d-pointer.
piggz updated this object.
piggz edited the test plan for this revision. (Show Details)
piggz added a reviewer: staniek.
Restricted Application added a project: KReport. · View Herald TranscriptOct 12 2016, 9:56 PM
staniek requested changes to this revision.Oct 12 2016, 10:52 PM
staniek edited edge metadata.

Minor comments.

src/common/KReportDocument.cpp
28

-> class Q_DECL_HIDDEN KReportDocument::Private

Please see T4016

190

not needed line

src/common/KReportDocument.h
74

' ;' -> ;

113–114

Please move these 2 lines to the very end line

This revision now requires changes to proceed.Oct 12 2016, 10:52 PM
piggz updated this revision to Diff 7379.Oct 13 2016, 5:11 PM
piggz edited edge metadata.
piggz marked 4 inline comments as done.
  • Fix minor review issues
staniek accepted this revision.Oct 13 2016, 5:24 PM
staniek edited edge metadata.

Good!

This revision is now accepted and ready to land.Oct 13 2016, 5:24 PM
This revision was automatically updated to reflect the committed changes.