When using a window switcher (alt + tab) that displays larger icon versions, konqueror's window icon looks ugly due to it only using a small icon which is being stretched.
Details
Details
Patch. Compile. Run, and once running alt+tab in a window switcher set to display large icons.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
| src/konqmainwindow.cpp | ||
|---|---|---|
| 4989 | QPixmap is bad. This is only a workaround. setWindowIcon takes a QIcon, let's give it one. Please test something like const QUrl url(QUrl::fromUserInput(m_combo->currentText()); const QIcon icon = QIcon::fromTheme(KonqPixmapProvider::self()->iconNameFor(url)); KParts::MainWindow::setWindowIcon(icon); Looks like it would be useful to have KonqPixmapProvider::iconForUrl() that calls QIcon::fromTheme internally, given all the code doing fromTheme(iconNameFor(u)), we could provide something more convenient. | |
Comment Actions
Thanks.
In a followup commit, feel free to port all uses of iconNameFor to iconForUrl :-)
At least all those who simply call QIcon::fromTheme on the result.