Cleanup and add 22px media repeat icons
ClosedPublic
Actions

Authored by astippich on Jan 14 2020, 8:56 PM.

Details

Reviewers

ngraham
ndavis

Group Reviewers

VDG

Commits

R266:936f84707708: Cleanup and add 22px media repeat icons

Summary

This patch does the following things:
-small cleanup to the existing 22px media-playlist-repeat icon
-adds a media-repeat-all symlink to media-playlist-repeat, which
exists for 32px icons
-adds a new 22px media-repeat-none icon

This makes the toggle repeat button in Elisa look sharp

Diff Detail

Repository

R266 Breeze Icons

Branch

repeatIcons

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 21167
Build 21185: arc lint + arc unit

astippich created this revision.Jan 14 2020, 8:56 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptJan 14 2020, 8:56 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

astippich requested review of this revision.Jan 14 2020, 8:56 PM

Harbormaster completed remote builds in B21148: Diff 73567.Jan 14 2020, 8:56 PM

Making monochrome breeze icons is tricky; you'll want to read https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips if you haven't already.

Also, screenshots using the Cuttlefish app are appreciated. :)

icons-dark/actions/22/media-playlist-repeat.svg
10	Remove `color="#eff0f1"`
icons/actions/22/media-playlist-repeat.svg
3	remove `color="#232629"`
icons/actions/22/media-repeat-none.svg
12	remove `color="#da4453"`

This revision now requires changes to proceed.Jan 14 2020, 11:37 PM

remove color

Harbormaster completed remote builds in B21167: Diff 73592.Jan 15 2020, 7:18 AM

here you go:

LGTM. @ndavis?

This revision is now accepted and ready to land.Jan 15 2020, 5:01 PM

ndavis accepted this revision.Jan 15 2020, 6:07 PM

Closed by commit R266:936f84707708: Cleanup and add 22px media repeat icons (authored by astippich). · Explain WhyJan 18 2020, 12:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		icons-dark/actions/22/media-playlist-repeat.svg (20 lines)
A	M	icons-dark/actions/22/media-repeat-all.svg (1 line)
A	M	icons-dark/actions/22/media-repeat-none.svg (14 lines)
M		icons/actions/22/media-playlist-repeat.svg (22 lines)
A	M	icons/actions/22/media-repeat-all.svg (1 line)
A	M	icons/actions/22/media-repeat-none.svg (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	73567	2f00ca3		Jan 14 2020, 8:56 PM	★	★
Diff 2	73592	2f00ca3	- remove color	Jan 15 2020, 7:17 AM	★	★
Diff 3	73823	22286e6	R266:936f847077085f13bd02134431bf149d71d45ce3	Jan 18 2020, 12:03 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
9c88b0926a93	c0dff57c8841	0e7c17145e7b	Alexander Stippich	remove color	Jan 15 2020, 7:04 AM
0e7c17145e7b	556edef0106d	accb3b8b8b0f	Alexander Stippich	Cleanup and add 22px media repeat icons (Show More…)	Jan 12 2020, 11:24 AM
accb3b8b8b0f	e4f2e98d9f03	2f00ca39d5ad	Alexander Stippich	rework and add 22px media repeat icons	Jan 12 2020, 11:21 AM