Allow to also pass a target instead of list of sources to KCONFIG_ADD_KCFG_FILES
ClosedPublic

Authored by davidre on Jan 13 2020, 2:16 PM.

Details

Summary

Brings us one step to closer to not needing to create lists of source files

Diff Detail

Repository
R237 KConfig
Branch
target (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21076
Build 21094: arc lint + arc unit
davidre created this revision.Jan 13 2020, 2:16 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 13 2020, 2:16 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidre requested review of this revision.Jan 13 2020, 2:16 PM

While touching this file, you might want to fix this file and make it self-contained by also having a include(CMakeParseArguments) at the begin, could be done as direct commit, no review needed IMHO :)

No comment on the actual new method API, I yet have to get used to the idea of direct target handling like target_sources, so lacking sense if the proposal is good.

KF5ConfigMacros.cmake
36

I propose to rename _sources to _target_or_source_var to make the code less surprising.

davidre removed a subscriber: kossebau.EditedJan 13 2020, 3:20 PM

For context as I'm not very proficient in CMake this is mostly a copy of D22698

Sorry for removing you, I had accidentally opened the change subscribers lineedit

apol accepted this revision.Jan 13 2020, 4:18 PM
apol added a subscriber: apol.

Makes sense, thanks David!

Please address kossebau's comments before landing.

This revision is now accepted and ready to land.Jan 13 2020, 4:18 PM
davidre updated this revision to Diff 73455.Jan 13 2020, 7:19 PM
davidre marked an inline comment as done.

target_or_source_var

This revision was automatically updated to reflect the committed changes.