When I added the subtitle feature, I didn't notice that the bottom margin calculation
was only including the original single label. This patch fixes that to include the
subtitle, if present.
Details
- Reviewers
broulik davidedmundson - Group Reviewers
VDG Plasma - Commits
- R296:083b21c4073f: Correctly compute bottom margin for grid delegates with subtitles
With D26531 applied, before:
After:
Diff Detail
- Repository
- R296 KDeclarative
- Branch
- compute-bottom-margin-correctly (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 21069 Build 21087: arc lint + arc unit
Oh wow, I just noticed that putting these labels in a ColumnLayout triggered the infamous QML text kerning bug! https://bugreports.qt.io/browse/QTBUG-49646
Could that be a clue to solving it maybe?
Seeing this now, I can revert the change to use a ColumnLayout. But it's interesting to see it reproducing like this. Can anyone else confirm?
src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml | ||
---|---|---|
81 | Maybe need to add caption.visible check, instead of always removing 3 gridUnits? |
src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml | ||
---|---|---|
81 | If I do that, then grids where some delegates have captions and others don't display delegates of multiple sizes, which looks bad: |
Then, is it an option to create GridDelegateSubtitles.qml instead?
As is now, without subtitles, I see everywhere squash shapes and bigger than necessary empty space.
now vs before
Image is wrong. Made an error.
That's what you see with this patch? That's not what I see, weird. For me, with the patch, I see the following for grids without subtitles: