Differential D26580

Kicker/RecentDocuments display place's icon when resource matches one
ClosedPublic
Actions

Authored by meven on Jan 11 2020, 11:14 AM.

Details

Reviewers
ngraham
hein
Group Reviewers
Plasma
Commits
R120:b51fb9dc522b: Kicker/RecentDocuments display place's icon when resource matches one

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20950
Build 20968: arc lint + arc unit
meven created this revision.Jan 11 2020, 11:14 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 11 2020, 11:14 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Jan 11 2020, 11:14 AM
meven updated this revision to Diff 73267.Jan 11 2020, 12:27 PM

RecentUsageModel Allow to open smb:/ sftp:/ resources

meven updated this revision to Diff 73268.Jan 11 2020, 12:29 PM

Undo unintended change

meven added a reviewer: hein.Jan 11 2020, 1:27 PM
ngraham accepted this revision.Jan 11 2020, 5:25 PM

Very nice, a big improvement visually. Make sure @hein or another Plasma person is good with this too.

This revision is now accepted and ready to land.Jan 11 2020, 5:25 PM
meven added a comment.Jan 18 2020, 8:05 AM

ping @hein
Might be good to go to plasma 5.18

meven added a comment.Jan 21 2020, 9:32 AM

I am thinking about merging this and push to 5.18 branch, this ought to be in 5.18.

hein accepted this revision.Jan 21 2020, 2:56 PM

This patch is fine and in line with the existing implementation, but it occurs to me we probably should make the RecentUsageModel use FileEntry and put it centrally there at some point.

meven added a comment.Jan 21 2020, 3:51 PM
In D26580#598081, @hein wrote:

This patch is fine and in line with the existing implementation, but it occurs to me we probably should make the RecentUsageModel use FileEntry and put it centrally there at some point.

Good idea

Should I push to 5.18 branch ?

ngraham added a comment.Jan 21 2020, 4:42 PM

Yes please.

Closed by commit R120:b51fb9dc522b: Kicker/RecentDocuments display place's icon when resource matches one (authored by meven). · Explain WhyJan 22 2020, 7:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 73267

View Options

applets/kicker/plugin/recentusagemodel.h

Loading...
View Options

applets/kicker/plugin/recentusagemodel.cpp

Loading...