Differential D25679

Implement writing of front cover in taglibwriter
AbandonedPublic
Actions

Authored by astippich on Dec 2 2019, 8:32 AM.

Details

Reviewers
bruns
mgallien
ngraham
Group Reviewers
Baloo
Summary

Complements the extractor support for writing
images.

Diff Detail

Repository
R286 KFileMetaData
Branch
tagLibBinaryWrite
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20829
Build 20847: arc lint + arc unit
astippich created this revision.Dec 2 2019, 8:32 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptDec 2 2019, 8:32 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Dec 2 2019, 8:32 AM
astippich updated this revision to Diff 73099.Jan 8 2020, 8:30 PM
  • adapt to changes
ngraham accepted this revision.Mar 16 2020, 5:32 PM
This revision is now accepted and ready to land.Mar 16 2020, 5:32 PM
bruns added inline comments.Mar 16 2020, 6:23 PM
src/writers/taglibwriter.cpp
78

https://doc.qt.io/qt-5/qmimedatabase.html#mimeTypeForData

85

This list is incomplete - there are also plain jpegs which start with a huffmann table, and Adobe apparent writes ones which start with an FFEE application marker.

astippich updated this revision to Diff 77959.Mar 18 2020, 7:07 PM
  • adapt to changes
  • use QMimeDatabase
astippich abandoned this revision.Apr 19 2020, 6:51 PM

Revision Contents
Changeset List

Diff 73099

View Options

autotests/taglibwritertest.cpp

Loading...
View Options

src/writers/taglibwriter.cpp

Loading...