Differential D26309

feat: replace replication source with logical size API
ClosedPublic
Actions

Authored by romangg on Dec 30 2019, 11:00 PM.

Details

Reviewers

None

Group Reviewers

KWin

Commits

R110:6a5a180bbedf: feat: replace replication source with logical size API

Summary

Just overriding the logical size of an output that replicates another one is
simpler than trying to send a relation between both objects to the display
server and in case of X11 it is not possible.

Wires up support for that in the X11 backend.

Test Plan

Compiles. Wayland replication tested.

Diff Detail

Repository

R110 KScreen Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

romangg created this revision.Dec 30 2019, 11:00 PM

Restricted Application added a project: Plasma. · View Herald TranscriptDec 30 2019, 11:00 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

romangg requested review of this revision.Dec 30 2019, 11:00 PM

Harbormaster completed remote builds in B20427: Diff 72428.Dec 30 2019, 11:00 PM

romangg added a dependency: D26308: Set output device's logical size.Dec 30 2019, 11:00 PM

romangg added a dependent revision: D26310: feat: use Control and logical size APIs for replicas.Dec 30 2019, 11:10 PM

Remove support in Wayland backend
Add support in RandR backend

Harbormaster completed remote builds in B20709: Diff 72890.Jan 6 2020, 2:14 PM

romangg edited the summary of this revision. (Show Details)Jan 6 2020, 2:17 PM

romangg removed a dependency: D26308: Set output device's logical size.Jan 6 2020, 9:29 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 7 2020, 2:56 PM

Closed by commit R110:6a5a180bbedf: feat: replace replication source with logical size API (authored by romangg). · Explain Why

This revision was automatically updated to reflect the committed changes.

romangg mentioned this in D26310: feat: use Control and logical size APIs for replicas.Jan 7 2020, 3:54 PM

Revision Contents
Changeset List

			Path	Packages
M			backends/xrandr/xrandrconfig.h (1 line)
M			backends/xrandr/xrandrconfig.cpp (67 lines)
M			backends/xrandr/xrandroutput.h (20 lines)
M			backends/xrandr/xrandroutput.cpp (135 lines)
M			src/output.h (34 lines)
M			src/output.cpp (50 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	72428	08a8259		Dec 30 2019, 11:00 PM	★	★
Diff 2	72890	08a8259	- Remove support in Wayland backend	Jan 6 2020, 2:14 PM	★	★
Diff 3	72977	08a8259	R110:6a5a180bbedf4f6721c4a5dd48f69c30d2140223	Jan 7 2020, 2:57 PM	★	★

Status	Author	Revision
Closed	romangg	D26481 feat(kcm): control scale
Closed	romangg	D26310 feat: use Control and logical size APIs for replicas
Closed	romangg	D26220 feat: control replication
Closed	romangg	D26309 feat: replace replication source with logical size API