Migrate config from KConfig to KConfigXt in order to allow KCM to use it
ClosedPublic

Authored by bport on Jan 3 2020, 5:46 PM.

Diff Detail

Repository
R293 Baloo
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 20720
Build 20738: arc lint + arc unit
bport created this revision.Jan 3 2020, 5:46 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJan 3 2020, 5:46 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
bport requested review of this revision.Jan 3 2020, 5:46 PM
ervin requested changes to this revision.Jan 6 2020, 2:03 PM

Two smaller issues, nothing critical

src/file/baloosettings.kcfgc
7

I don't think GenerateProperties is useful here. We don't use the property system in the generated class.

src/file/fileindexerconfig.cpp
118–119

I guess this TODO comment can go with your change.

This revision now requires changes to proceed.Jan 6 2020, 2:03 PM
bport updated this revision to Diff 72908.Jan 6 2020, 4:47 PM

Take in consideration ervin feedback

ervin accepted this revision.Jan 6 2020, 4:55 PM
This revision is now accepted and ready to land.Jan 6 2020, 4:55 PM
ervin accepted this revision.Jan 6 2020, 5:19 PM
This revision was automatically updated to reflect the committed changes.