Differential D26385

Kicker/RecentDocuments Avoid referring to hidden places
AbandonedPublic
Actions

Authored by meven on Jan 3 2020, 10:30 AM.

Details

Reviewers
ngraham
hein
Group Reviewers
Plasma
Commits
R120:aa259e389848: Kicker/RecentDocuments Avoid referring to hidden places

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Jan 3 2020, 10:30 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 3 2020, 10:30 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Jan 3 2020, 10:30 AM
ngraham accepted this revision.Jan 3 2020, 3:24 PM
This revision is now accepted and ready to land.Jan 3 2020, 3:24 PM
Closed by commit R120:aa259e389848: Kicker/RecentDocuments Avoid referring to hidden places (authored by meven). · Explain WhyJan 3 2020, 4:41 PM
This revision was automatically updated to reflect the committed changes.
hein added a subscriber: hein.Jan 3 2020, 7:09 PM

I don't agree with this patch. Hiding a place or section from the Places panel doesn't mean the user didn't add it and it's not to be used. We don't hide it from Folder View's config or relative title generator either. Hidden is not removed. Please revert.

hein reopened this revision.Jan 3 2020, 7:09 PM
This revision is now accepted and ready to land.Jan 3 2020, 7:09 PM
hein requested changes to this revision.Jan 3 2020, 7:09 PM
This revision now requires changes to proceed.Jan 3 2020, 7:09 PM
meven added a comment.Jan 3 2020, 7:22 PM
In D26385#587173, @hein wrote:

I don't agree with this patch. Hiding a place or section from the Places panel doesn't mean the user didn't add it and it's not to be used. We don't hide it from Folder View's config or relative title generator either. Hidden is not removed. Please revert.

I meant to do this, as the use might be confused to discover a place name he never sees.
For instance "Hard disk (400 GB)" (mountpoint /) might be hidden but will be the prefix to all local files not in other places.
To me it is confusing, but for consistency let's keep those visible.

Reverted in 4446d687d337dc3f33fc50ca65a8beb161367204

hein added a comment.Jan 3 2020, 7:30 PM

Thanks!

We can revisit it after some more discussion.

meven abandoned this revision.Jan 4 2020, 4:11 PM

Revision Contents
Changeset List

Diff 72696

View Options

applets/kicker/plugin/recentusagemodel.cpp

Loading...