[applets/digital-clock] Fix truncated Long Date display in a vertical panel
ClosedPublic

Authored by ngraham on Dec 30 2019, 11:54 PM.

Details

Summary

BUG: 381551
FIXED-IN: 5.18.0

Test Plan

Before:

After:

Texted extensively because this code is so brittle. No regressions with long date in a
thick or normal-sized horizontal panel or short date in a thick or normal-sized
horizontal or vertical panel.

The one issue I could find is that sometimes switching between short and long date
formats in a double-thickness vertical panel causes the long date to be truncated again
until plasmashell is restarted. I was unable to determine why. Assistance would be
appreciated if this is a blocker.

Diff Detail

Repository
R120 Plasma Workspace
Branch
fix-clock-long-date-in-vertical-panel (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20584
Build 20602: arc lint + arc unit
ngraham created this revision.Dec 30 2019, 11:54 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 30 2019, 11:54 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Dec 30 2019, 11:54 PM
ngraham updated this revision to Diff 72435.Dec 31 2019, 12:16 AM

Simplify; still works

ndavis accepted this revision.EditedJan 3 2020, 6:49 AM
ndavis added a subscriber: ndavis.

This works for me. Is it possible to enforce a minimum font size equal to either the general or small font settings?

This revision is now accepted and ready to land.Jan 3 2020, 6:49 AM
ndavis requested changes to this revision.Jan 3 2020, 6:59 AM

Actually, this does have some negative effects on the appearance.

before:

after:

This revision now requires changes to proceed.Jan 3 2020, 6:59 AM
ngraham updated this revision to Diff 72692.Jan 3 2020, 3:49 PM

Fix that issue

ndavis accepted this revision.Jan 4 2020, 2:54 AM
This revision is now accepted and ready to land.Jan 4 2020, 2:54 AM

Plasma folks, does the way I've changed this make sense?

This revision was automatically updated to reflect the committed changes.