Also add an open containing folder action
Details
Details
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| applets/kicker/plugin/recentusagemodel.cpp | ||
|---|---|---|
| 278 | Can you use the "~" for HOME like the runners do please | |
| applets/kicker/plugin/recentusagemodel.cpp | ||
|---|---|---|
| 278 | I am thinking about adding this utility feature to KCoreAddons and avoid more duplication. | |
| applets/kicker/plugin/recentusagemodel.cpp | ||
|---|---|---|
| 278 | ||
Comment Actions
Hmm, as your screenshot indicates, the subtitle is not very useful because it usually gets elided:
Not a -1, but I wonder how useful this will be in practice.
However big +1 on adding an "Open containing folder" menu item. Maybe that should be in a separate patch so it can go in quickly and we can discuss the subtitle separately>
Comment Actions
Hmm, as your screenshot indicates, the subtitle is not very useful because it usually gets elided:
Not a -1, but I wonder how useful this will be in practice.
However big +1 on adding an "Open containing folder" menu item. Maybe that should be in a separate patch so it can go in quickly and we can discuss the subtitle separately>
I think it could be useful if there are multiple files with the same name
Comment Actions
Actually I see that other list items on other tabs already have path captions like this, so it's not a newly-introduced issue.
| applets/kicker/plugin/recentusagemodel.cpp | ||
|---|---|---|
| 384 | Probably worth just doing this in a single line rather than defining a variable used only once | |
| applets/kicker/plugin/recentusagemodel.cpp | ||
|---|---|---|
| 384 | I did this for readability, I think we should keep this. KIO::highlightInFileManager({QUrl::fromUserInput(resourceAt(row))}); | |
Comment Actions
Hmm, as your screenshot indicates, the subtitle is not very useful because it usually gets elided:
Not a -1, but I wonder how useful this will be in practice.
However big +1 on adding an "Open containing folder" menu item. Maybe that should be in a separate patch so it can go in quickly and we can discuss the subtitle separately>
Your screenshot made me think, we might want to replace for instance "/var/run/100/kio..." but the user friendly name that dolphin would display in places when the path correspond to a mounted place or a place, i.e "Pictures" instead of "~/Pictures".
Like dolphin breadcrumbs does basically.
Comment Actions
Nice, I think this makes sense. Now Kickoff's Computer tab needs the same treatment or else the paths are oddly inconsistent.
Comment Actions
No need to update here after D26122, the code uses now KFilePlacesModel to replace all places'path by their name rather than just ~.