| davidedmundson |
| KWin |
This patch adds interfaces for specifying viewports via the wp_viewporter
protocol extension. This allows to make surface size and buffer independent
from each other. For example a video player can send 1080p video data while
the window of the player is of different size.
The server interface ViewportInterface is directly integrated with
SurfaceInterface. Viewport changes are double-buffered by that.
Added auto tests and with weston-scaler.
| Lint Errors | Excuse: unrelated code |
| Severity | Location | Code | Message |
|---|---|---|---|
| Error | src/client/datadevicemanager.h:76 | Cppcheck | unknownMacro |
| Error | src/server/textinput_interface.h:160 | Cppcheck | unknownMacro |
| No Unit Test Coverage |
| Buildable 20509 | |
| Build 20527: arc lint + arc unit |
| src/server/surface_interface.h | ||
|---|---|---|
| 128 | Needed for a call in a const function in KWin. Do we want to do it like that? Other suggestions? | |
Cool, I like viewporter.
| src/server/surface_interface.cpp | ||
|---|---|---|
| 509 | C-style casts are frowned upon. | |
| 530 | We're not testing this error in the case of: buffer is set then later this should be an error too. | |
| 906 | Should this be d->current.sourceRectangle.size()/ scale() It would be a somewhat weird case to use both viewporter and wl_buffer.scale, but it's what the spec implies and you seem to be assuming that in the kwin render path. destinationSize would be as-is. | |
| src/server/surface_interface.h | ||
| 128 | Why not just BufferInterface *buffer() const There's no reason why a caller would need to explicitly pick a const vs non-const version. | |
| src/server/surface_interface.cpp | ||
|---|---|---|
| 530 | Good point. Same should be done for when the transform or scale changes. | |
| 906 | How I read the spec: the source rectangle is always specified in coordinates after scale and transform. [1] SurfaceInterface::size() returns the scaled and transformed (not yet) buffer size so since viewporter coordinates are to this base we can just directly return them. | |
| src/server/surface_interface.h | ||
| 128 | Yea, I added the new function for API/ABI-compatibility. But if you say making the function buffer() const is not a problem in this regard I will gladly do that. | |
| src/server/surface_interface.cpp | ||
|---|---|---|
| 906 | Yeah, on re-reading I think your intepretation is right. Leave your stuff as-is. | |