Details

Reviewers

ognarb
mpyne

Commits

R928:397eb218cdca: Converted site to jekyll

Diff Detail

Repository

R928 Juk Website

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 20121
Build 20139: arc lint + arc unit

anujbansal requested review of this revision.Dec 8 2019, 3:58 PM

anujbansal created this revision.

Harbormaster completed remote builds in B19598: Diff 71090.Dec 8 2019, 3:58 PM

anujbansal added a reviewer: ognarb.Dec 8 2019, 4:01 PM

Added Jekyll Config

Harbormaster completed remote builds in B19612: Diff 71112.Dec 9 2019, 10:04 AM

ognarb mentioned this in T10827: Website redesign.Dec 9 2019, 10:10 AM

Updated site to jekyll

Harbormaster completed remote builds in B20032: Diff 71815.Dec 18 2019, 7:56 PM

Added Readme

Harbormaster completed remote builds in B20033: Diff 71816.Dec 18 2019, 8:00 PM

anujbansal retitled this revision from Updated links for loading and clear gifs to Converted site to jekyll.Dec 18 2019, 8:02 PM

anujbansal edited the summary of this revision. (Show Details)

Updated Screenshots

Harbormaster completed remote builds in B20058: Diff 71851.Dec 19 2019, 6:15 PM

Added footer and changed screenshot layout

Harbormaster completed remote builds in B20121: Diff 71949.Dec 21 2019, 2:39 PM

Updated Contact section

Harbormaster completed remote builds in B20123: Diff 71951.Dec 21 2019, 2:53 PM

Please remove the following auto generated files:

.sass-cache
.bundle

Can you also remove the images that are no longer used? We don't need them anymore.

Can you also change 'KDE JuK - KDE JuK Media Player' to 'Juk - KDE Jukebox'?

Otherwise, the redesign looks good.

Also adding @mpyne as reviewer, maybe he can provide more feedback :-) and maybe for you the cover manager work so we can have a better screenshot of it ;)

This revision now requires changes to proceed.Dec 22 2019, 4:07 PM

Added .gitignore

Harbormaster completed remote builds in B20156: Diff 72002.Dec 22 2019, 4:34 PM

LGTM from my side, let's wait for comment from @mpyne :)

This revision is now accepted and ready to land.Dec 22 2019, 5:16 PM

Looks good to me as well. Thanks for the work on this!

I created https://invent.kde.org/sysadmin/binary-factory-tooling/merge_requests/43. When this is merged we can push this change.

Closed by commit R928:397eb218cdca: Converted site to jekyll (authored by anujbansal, committed by ognarb). · Explain WhyDec 26 2019, 10:06 PM

This revision was automatically updated to reflect the committed changes.

			Path
A	M		.bundle/config (2 lines)
A	M	(bin)	.sass-cache/60d313b80a9ce941dbd1aa51a2fae4959adcd1d3/download.scssc
A	M	(bin)	.sass-cache/60d313b80a9ce941dbd1aa51a2fae4959adcd1d3/home.scssc
A	M		Gemfile (10 lines)
A	M		Gemfile.lock (74 lines)
A	M		README.md (22 lines)
A	M		_config.yml (45 lines)
V		(img)	{assets/img/app_icon.png ← favicon.png}
A	M	(img)	assets/img/covermanager.png
A	M	(img)	assets/img/createplaylist.png
V		(img)	{assets/img ← img/screenshots}/juk-3.10.1-about.png
V		(img)	{assets/img ← img/screenshots}/juk-3.10.1-cd.png
V		(img)	{assets/img ← img/screenshots}/juk-3.10.1-cover_found.png
V		(img)	{assets/img ← img/screenshots}/juk-3.10.1-cover_mgr.png
V		(img)	{assets/img ← img/screenshots}/juk-3.10.1-lyrics.png
V		(img)	{assets/img ← img/screenshots}/juk-3.10.1-main.png
V		(img)	{assets/img ← img/screenshots}/juk-3.10.1-notify.png
V		(img)	{assets/img ← img/screenshots}/juk-3.10.1-search.png
V		(img)	{assets/img ← img/screenshots}/juk-3.10.1-tag.png
V		(img)	{assets/img ← img/screenshots}/juk-3.10.1-tag_guess.png
V		(img)	{assets/img ← img/screenshots}/juk-3.10.1-tag_line.png
V		(img)	{assets/img ← img/screenshots}/juk-3.10.1-tag_multi.png
V		(img)	{assets/img ← img/screenshots}/juk-3.10.1-tree.png
A	M	(img)	assets/img/lyrics.png
A	M	(img)	assets/img/multiline.png
A	M	(img)	assets/img/screenshot.png
A	M	(img)	assets/img/search.png
A	M	(img)	assets/img/tag.png
D	M		css/bootstrap.min.css (9 lines)
A	M		css/main.scss (17 lines)
D	M		css/sliderman.css (64 lines)
V		(img)	{favicon.png → assets/img/app_icon.png}
D	M	(img)	img/screenshots/juk-1.png
V		(img)	{img/screenshots → assets/img}/juk-3.10.1-about.png
V		(img)	{img/screenshots → assets/img}/juk-3.10.1-cd.png
V		(img)	{img/screenshots → assets/img}/juk-3.10.1-cover_found.png
V		(img)	{img/screenshots → assets/img}/juk-3.10.1-cover_mgr.png
V		(img)	{img/screenshots → assets/img}/juk-3.10.1-lyrics.png
V		(img)	{img/screenshots → assets/img}/juk-3.10.1-main.png
V		(img)	{img/screenshots → assets/img}/juk-3.10.1-notify.png
V		(img)	{img/screenshots → assets/img}/juk-3.10.1-search.png
V		(img)	{img/screenshots → assets/img}/juk-3.10.1-tag.png
V		(img)	{img/screenshots → assets/img}/juk-3.10.1-tag_guess.png
V		(img)	{img/screenshots → assets/img}/juk-3.10.1-tag_line.png
V		(img)	{img/screenshots → assets/img}/juk-3.10.1-tag_multi.png
V		(img)	{img/screenshots → assets/img}/juk-3.10.1-tree.png
D	M	(img)	img/slider/bg.png
D	M	(img)	img/slider/bullet.png
D	M	(img)	img/slider/bullet_active.png
D	M	(img)	img/slider/clear.gif
D	M	(img)	img/slider/left.png
D	M	(img)	img/slider/loading.gif
D	M	(img)	img/slider/right.png
M			index.html (488 lines)
D	M		js/bootstrap.min.js (9 lines)
D	M		js/jquery-1.3.2.min.js (19 lines)
D	M		js/jquery.min.js (6 lines)
D	M		js/sliderman.1.3.7.js (930 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	71090	679f6d2		Dec 8 2019, 3:58 PM	★	★
Diff 2	71112	679f6d2	- Added Jekyll Config	Dec 9 2019, 10:04 AM	★	★
Diff 3	71815	679f6d2	- Updated site to jekyll	Dec 18 2019, 7:56 PM	★	★
Diff 4	71816	679f6d2	Added Readme	Dec 18 2019, 8:00 PM	★	★
Diff 5	71851	679f6d2	- Updated Screenshots	Dec 19 2019, 6:15 PM	★	★
Diff 6	71949	679f6d2	- Added footer and changed screenshot layout	Dec 21 2019, 2:38 PM	★	★
Diff 7	71951	679f6d2	- Updated Contact section	Dec 21 2019, 2:53 PM	★	★
Diff 8	72002	679f6d2	- Added .gitignore	Dec 22 2019, 4:34 PM	★	★
Diff 9	72222	679f6d2	R928:397eb218cdcad9c14e912bd7262f81a3dcc6f638	Dec 26 2019, 10:04 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
e5338538a483	698bc4383a2d	63200d41ec6a	Anuj Bansal	Added footer and changed screenshot layout	Dec 21 2019, 2:37 PM
63200d41ec6a	2e91805b6424	22e6d0404675	Anuj Bansal	Updated Screenshots	Dec 19 2019, 6:14 PM
22e6d0404675	0b0b6bd16de9	a297fab838c6	Anuj Bansal	Updated site to jekyll	Dec 18 2019, 7:54 PM
a297fab838c6	8fbc9682500d	1e94baa5a7be	Anuj Bansal	Added Jekyll Config	Dec 9 2019, 10:04 AM
1e94baa5a7be	f57df8793dcd	679f6d2174d5	Anuj Bansal	Updated links for loading and clear gifs (Show More…)	Dec 8 2019, 3:34 PM

Converted site to jekyllClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 71949

.bundle/config

.sass-cache/60d313b80a9ce941dbd1aa51a2fae4959adcd1d3/download.scssc

.sass-cache/60d313b80a9ce941dbd1aa51a2fae4959adcd1d3/home.scssc

Gemfile

Gemfile.lock

README.md

_config.yml

assets/img/app_icon.png

assets/img/covermanager.png

assets/img/createplaylist.png

assets/img/juk-3.10.1-about.png

assets/img/juk-3.10.1-cd.png

assets/img/juk-3.10.1-cover_found.png

assets/img/juk-3.10.1-cover_mgr.png

assets/img/juk-3.10.1-lyrics.png

assets/img/juk-3.10.1-main.png

assets/img/juk-3.10.1-notify.png

assets/img/juk-3.10.1-search.png

assets/img/juk-3.10.1-tag.png

assets/img/juk-3.10.1-tag_guess.png

assets/img/juk-3.10.1-tag_line.png

assets/img/juk-3.10.1-tag_multi.png

assets/img/juk-3.10.1-tree.png

assets/img/lyrics.png

assets/img/multiline.png

assets/img/screenshot.png

assets/img/search.png

assets/img/tag.png

css/bootstrap.min.css

css/main.scss

css/sliderman.css

favicon.png

img/screenshots/juk-1.png

img/screenshots/juk-3.10.1-about.png

img/screenshots/juk-3.10.1-cd.png

img/screenshots/juk-3.10.1-cover_found.png

img/screenshots/juk-3.10.1-cover_mgr.png

img/screenshots/juk-3.10.1-lyrics.png

img/screenshots/juk-3.10.1-main.png

img/screenshots/juk-3.10.1-notify.png

img/screenshots/juk-3.10.1-search.png

img/screenshots/juk-3.10.1-tag.png

img/screenshots/juk-3.10.1-tag_guess.png

img/screenshots/juk-3.10.1-tag_line.png

img/screenshots/juk-3.10.1-tag_multi.png

img/screenshots/juk-3.10.1-tree.png

img/slider/bg.png

img/slider/bullet.png

img/slider/bullet_active.png

img/slider/clear.gif

img/slider/left.png

img/slider/loading.gif

img/slider/right.png

index.html

js/bootstrap.min.js

js/jquery-1.3.2.min.js

js/jquery.min.js

js/sliderman.1.3.7.js

Converted site to jekyll
ClosedPublic
Actions

Revision Contents
Changeset List