[KCM/NightColor] Allow the user to know the default settings are selected
ClosedPublic

Authored by meven on Dec 16 2019, 4:04 PM.

Details

Test Plan

kcmshell5 kcm_nightcolor
Checked all settings reacts correctly to the restore defaults button

Diff Detail

Repository
R119 Plasma Desktop
Branch
nightcolor-default
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20018
Build 20036: arc lint + arc unit
meven created this revision.Dec 16 2019, 4:04 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 16 2019, 4:04 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Dec 16 2019, 4:04 PM
meven updated this revision to Diff 71714.Dec 17 2019, 12:58 PM

[KCM/Access] Port to use KConfigXT

meven planned changes to this revision.Dec 17 2019, 12:59 PM
meven updated this revision to Diff 71715.Dec 17 2019, 1:04 PM

clean up diff

meven updated this revision to Diff 71725.Dec 17 2019, 2:49 PM

Mark state as default when nightcolor is not available

romangg added inline comments.Dec 17 2019, 3:36 PM
kcms/nightcolor/package/contents/ui/main.qml
65

What is this supposed to do?

meven added inline comments.Dec 17 2019, 3:59 PM
kcms/nightcolor/package/contents/ui/main.qml
65

Disable the restore default button

meven updated this revision to Diff 71730.Dec 17 2019, 4:02 PM
meven marked 2 inline comments as done.

Fix

romangg accepted this revision.Dec 17 2019, 4:16 PM

Looks good to me. Maybe someone besides me who worked more recently on the KCM wants to give his ok as well. If nothing comes in till tomorrow, push. Thanks.

This revision is now accepted and ready to land.Dec 17 2019, 4:16 PM
meven updated this revision to Diff 71790.Dec 18 2019, 2:49 PM

Remove unnecessary call

davidedmundson accepted this revision.Dec 18 2019, 2:56 PM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
kcms/nightcolor/package/contents/ui/main.qml
88

Please split.

meven updated this revision to Diff 71795.Dec 18 2019, 3:25 PM

Add a space for form

meven added a comment.Dec 18 2019, 3:26 PM

FYI the restore button is currently always enabled on load even if parameters represent the default ones.
I have a fix proposal at : https://phabricator.kde.org/D26085

This revision was automatically updated to reflect the committed changes.