[KCM/Activity] Use KConfigXT to store settings
ClosedPublic

Authored by meven on Dec 17 2019, 3:57 PM.

Details

Test Plan

kcmshell5 kcm_activities
Changed settings, restored defaults

Diff Detail

Repository
R119 Plasma Desktop
Branch
activity_kcm
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19978
Build 19996: arc lint + arc unit
meven created this revision.Dec 17 2019, 3:57 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 17 2019, 3:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Dec 17 2019, 3:57 PM
meven updated this revision to Diff 71729.Dec 17 2019, 4:00 PM

Ensure the black list opt-in checkbox change apply button state

ervin accepted this revision.Dec 23 2019, 12:48 PM
ervin added inline comments.
kcms/activities/PrivacyTab.cpp
50

I'd have it by pointer and give it a parent at construction time. It's a more common pattern for QObject as members.

51

Ditto

This revision is now accepted and ready to land.Dec 23 2019, 12:48 PM
ervin requested changes to this revision.Dec 23 2019, 12:48 PM

Oops, selected wrong state :-)

This revision now requires changes to proceed.Dec 23 2019, 12:48 PM
meven updated this revision to Diff 72089.Dec 23 2019, 3:18 PM

Make pluginConfig and mainConfig pointers

meven updated this revision to Diff 72091.Dec 23 2019, 3:25 PM

Fix * position

ervin requested changes to this revision.Dec 23 2019, 3:27 PM
ervin added inline comments.
kcms/activities/PrivacyTab.cpp
58

Space before * not after

This revision now requires changes to proceed.Dec 23 2019, 3:27 PM
meven updated this revision to Diff 72093.Dec 23 2019, 3:37 PM
meven marked 3 inline comments as done.

Fix position of *

ervin accepted this revision.Dec 23 2019, 3:38 PM
This revision is now accepted and ready to land.Dec 23 2019, 3:38 PM
This revision was automatically updated to reflect the committed changes.
davidedmundson added inline comments.
kcms/activities/PrivacyTab.cpp
65

Why do we explicitly call deleteLater on these?

meven added inline comments.Dec 30 2019, 10:17 AM
kcms/activities/PrivacyTab.cpp
65

That was not needed, will clean up

meven added inline comments.Dec 30 2019, 11:07 AM
kcms/activities/PrivacyTab.cpp
65