kcmshell5 kcm_nightcolor
Checked all settings reacts correctly to the restore defaults button
Details
Details
- Reviewers
crossi ervin romangg davidedmundson - Group Reviewers
KWin - Commits
- R119:f1943a1e59ff: [KCM/NightColor] Allow the user to know the default settings are selected
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- kaccess-kconfigxt
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 19966 Build 19984: arc lint + arc unit
kcms/nightcolor/package/contents/ui/main.qml | ||
---|---|---|
65 | What is this supposed to do? |
kcms/nightcolor/package/contents/ui/main.qml | ||
---|---|---|
65 | Disable the restore default button |
Comment Actions
Looks good to me. Maybe someone besides me who worked more recently on the KCM wants to give his ok as well. If nothing comes in till tomorrow, push. Thanks.
kcms/nightcolor/package/contents/ui/main.qml | ||
---|---|---|
88 | Please split. |
Comment Actions
FYI the restore button is currently always enabled on load even if parameters represent the default ones.
I have a fix proposal at : https://phabricator.kde.org/D26085