Prevents compressing task's icons below the desired size, before grouping when vertical. While it allows to cut text when task bar is horizontal.
Gives a more uniform look and behavior, when the taskbar is vertical and icons determine the size of the task button.
Details
- Reviewers
hein ngraham - Group Reviewers
Plasma VDG - Commits
- R119:ae8732ed7799: Don't compress tasks before grouping, when task manager is vertical
This patch, was original part of icons-only grouping change that would include "Group only when the Task Manager is full" option.
Would be more important in a docker style of task manager.
For now this patch can only have an effect when:
Group only when the Task Manager is full == True
Maximum rows = 1
Taskbar is vertical
Icon width > taskbar width (easiest to test with Icon size == large)
For more obvious effect, adjust the taskbar width, at a point where it will just display a bigger icon size.
In the same space, without the patch, it will display more items by choosing smaller icon size.
By opening more tasks (reach the task display threshold), will be forced to group them, and will pop to a bigger display icon size again.
With the patch will keep the desired icon size, and instead will group them together.
In both cases will shrink the icon sizes further if more tasks need to fit.
In the photo can see, the taskbar without the patch will fit the same amount of tasks, in a smaller space by displaying a smaller size.
After grouping will increase the size back again.
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
So you want to be able to not group apps in IOTM, that is literally what IOTM is about, isnt it?
I don't know what the reasoning between splitting the task managers is.
But from what I understand, Icons-Only means no text.
And sorting is also removed.
applets/taskmanager/package/contents/ui/code/layout.js | ||
---|---|---|
88 | This has an effect mostly for small displays. On bigger displays this has a small effect. Math.Ceil(Math.floor(length / maximum) * maxStripes() * 1.25); |
Icons-Only implements the "Dock" paradigm and organizes things on the basis of apps, not windows. So the name doesn't make it clear, but the Icons-Only Task Manager is much more than just "the regular task manager without labels".
I'm not sure of the history behind why this split is presented in the form of two different applets rather than a single one with configurable options. In the backend, they're both using the same code so this is easily possible. Personally I would like for there to be a single task manager that exposes three different modes in the config window:
- Legacy Windows Vista and before mode (current default)
- ^^, but without labels (Windows 10 style with grouping mode turned off)
- macOS style Dock mode (current Icons-Only Task Manager)
This would call for some serious discussion before implementing it though.
@gvgeo since we already have a patch that disables grouping, maybe you could use this one to implement only the change to the compressing animation?
I'm not sure of the history behind why this split is presented in the form of two different applets
To give history
We had a UX in Plasma 4 where choosing between an analog and digital clock would be an option in the main clock applet, but choosing the binary clock would be a completely different interface - and that doesn't make sense.
Also we want to reduce the size of our config UIs without losing features.
Thanks David! So we moved in the direction of separating the presentation rather than grouping it. I almost wonder if it would make more sense to do the opposite thing group everything into a single applet wherever possible, but allow the presentation to be swapped at will--perhaps even with GHNS-downloadable themes or something. So there would be one clock applet, but it could look like an analog clock, a digital clock, a binary clock, or a fuzzy clock, and you could download a Mickey Mouse clock face, a Star Wars clock face, and so on.
My mistake, should have checked here too first.
I left only the compressing part for the default task manager.
Revert previous update, as D23242 does not enable 'Group only when the Task Manager is full' option.
I'm not sure how to reproduce the issue that this patch is fixing. Can you add more detail to the Test Plan section maybe?