[KCMs/Workspace] Add explanatory labels for click-related settings
ClosedPublic

Authored by ngraham on Dec 11 2019, 9:20 AM.

Details

Summary

This way the behavior of the related action is clear no matter which setting is chosen.

Diff Detail

Repository
R119 Plasma Desktop
Branch
explanatory-text (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19734
Build 19752: arc lint + arc unit
ngraham created this revision.Dec 11 2019, 9:20 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 11 2019, 9:20 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Dec 11 2019, 9:20 AM
ndavis added a subscriber: ndavis.Dec 11 2019, 4:48 PM
ndavis added inline comments.
kcms/workspaceoptions/package/contents/ui/main.qml
166

This is incorrect. Middle clicking still jumps to the clicked location.

ngraham added inline comments.Dec 11 2019, 11:16 PM
kcms/workspaceoptions/package/contents/ui/main.qml
166

Oh darn, so it does. I checked the docs and tried setting SH_ScrollBar_MiddleClickAbsolutePosition explicitly, but it looks like there's actually no option to do page-by-page navigation for clicking in the scroll track when using the left-click-warps-slider style :/

ngraham updated this revision to Diff 71328.Dec 11 2019, 11:24 PM

Only show the message when left-click-navigates-by-page mode is in use

ngraham marked 2 inline comments as done.Dec 11 2019, 11:25 PM

Sidenote, maybe an upstream bug / wish can be added about

	Oh darn, so it does. I checked the docs and tried setting SH_ScrollBar_MiddleClickAbsolutePosition explicitly, but it looks like there's actually no option to do page-by-page navigation for clicking in the scroll track when using the left-click-warps-slider style :/

Thanks for adding the help text :)

It's not a common pattern we do in plasma currently, but that doesn't necessarily mean we shouldn't use it.

kcms/workspaceoptions/package/contents/ui/main.qml
131

For almost all lablels:

Layout.fillWidth: true

either elide or wrap

ngraham updated this revision to Diff 71336.Dec 12 2019, 9:56 AM
ngraham marked an inline comment as done.

Fill width

ngraham updated this revision to Diff 71337.Dec 12 2019, 9:57 AM

...and elide

ngraham updated this revision to Diff 71340.Dec 12 2019, 10:18 AM

Add comment about the Qt situation

ngraham edited the test plan for this revision. (Show Details)Dec 12 2019, 5:28 PM
ngraham edited the test plan for this revision. (Show Details)

Ping.

If nobody likes this, I can just abandon it, but I'd appreciate some feedback one way or another. :)

Fuchs accepted this revision.Dec 27 2019, 6:57 PM

Good for me, hopefully the upstream bug will be fixed, too :)

This revision is now accepted and ready to land.Dec 27 2019, 6:57 PM
ndavis accepted this revision.Dec 27 2019, 7:19 PM
This revision was automatically updated to reflect the committed changes.