Differential D25871

[KCM/Desktop] Use KConfig XT to store virtualdesktops related settings
ClosedPublic
Actions

Authored by meven on Dec 11 2019, 7:54 AM.

Details

Reviewers

ervin

Group Reviewers

KWin

Commits

R108:930c2d69a714: [KCM/Desktop] Use KConfig XT to store virtualdesktops related settings

Summary

Use a kcfg file to specify virtual desktops settings saved to kwinrc.

Test Plan

kcmshell5 kcm_kwin_virtualdesktops
Change something, check apply buttons works appropriately
Save the settings and relaunch the kcm, the new settings are taken loaded correctly

Diff Detail

Repository

R108 KWin

Branch

use_kconfigxt

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 19683
Build 19701: arc lint + arc unit

meven created this revision.Dec 11 2019, 7:54 AM

Restricted Application added a project: KWin. · View Herald TranscriptDec 11 2019, 7:54 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

meven requested review of this revision.Dec 11 2019, 7:54 AM

Harbormaster completed remote builds in B19680: Diff 71245.Dec 11 2019, 7:54 AM

meven edited the summary of this revision. (Show Details)Dec 11 2019, 8:20 AM

meven edited the test plan for this revision. (Show Details)

meven edited the summary of this revision. (Show Details)Dec 11 2019, 8:23 AM

Mostly looks good, needs some tuning in the kcfg to make the generated code API nicer on the C++ side.

kcmkwin/kwindesktop/virtualdesktopssettings.kcfg
9	I'd use rollOverDesktop for the name parameter to have proper camel casing on the C++ side
15	I'd use desktopChangeOsdEnabled for the name parameter to have proper camel casing on the C++ side

This revision now requires changes to proceed.Dec 11 2019, 9:21 AM

Camel case kcfg entries names

Harbormaster completed remote builds in B19683: Diff 71253.Dec 11 2019, 9:43 AM

meven marked 2 inline comments as done.Dec 11 2019, 9:44 AM

ervin accepted this revision.Dec 11 2019, 9:45 AM

This revision is now accepted and ready to land.Dec 11 2019, 9:45 AM

Closed by commit R108:930c2d69a714: [KCM/Desktop] Use KConfig XT to store virtualdesktops related settings (authored by meven). · Explain WhyDec 11 2019, 10:02 AM

This revision was automatically updated to reflect the committed changes.

davidedmundson added a subscriber: davidedmundson.Dec 11 2019, 10:40 AM

davidedmundson added inline comments.

kcmkwin/kwindesktop/virtualdesktops.cpp
173	I would like this to to take these settings from the kcfg defaults
250	Out of curiosity, is there anything blocking us using KQuickAddons::ManagedConfigModule as the base?

ervin added inline comments.Dec 11 2019, 12:42 PM

kcmkwin/kwindesktop/virtualdesktops.cpp
173	Good point, definitely missing
250	Nothing, but Méven is going incremental here

meven added inline comments.Dec 11 2019, 12:44 PM

kcmkwin/kwindesktop/virtualdesktops.cpp
173	This was going to be removed anyway : D25881

crossi added a subscriber: crossi.Dec 11 2019, 2:28 PM

crossi added inline comments.Dec 11 2019, 2:37 PM

kcmkwin/kwindesktop/virtualdesktopssettings.kcfg
21	Should use popupHideDelay for name attribute
25	Should use textOnly for name attribute

Revision Contents
Changeset List

		Path
M		kcmkwin/kwindesktop/CMakeLists.txt (3 lines)
M		kcmkwin/kwindesktop/virtualdesktops.h (4 lines)
M		kcmkwin/kwindesktop/virtualdesktops.cpp (43 lines)
A	M	kcmkwin/kwindesktop/virtualdesktopssettings.kcfg (29 lines)
A	M	kcmkwin/kwindesktop/virtualdesktopssettings.kcfgc (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	71245	5114494		Dec 11 2019, 7:54 AM	★	★
Diff 2	71253	5114494	Camel case kcfg entries names	Dec 11 2019, 9:43 AM	★	★
Diff 3	71256	f6128ec	R108:930c2d69a71409790a000951c43cbeac4fab3f30	Dec 11 2019, 10:00 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
2b903a2e0ce6	f753797e06a8	5114494b57fe	Méven Car	[KCM/Desktop] Use KConfig XT to store virtualdesktops related settings (Show More…)	Dec 10 2019, 5:36 PM