Prior to this patch, when the engine was not correctly initialised,
it would cause the dialog title to be Download New %1. With this
patch, it will be Download New Stuff, whenever the engine's name
is empty (which can happen in a couple of situations)
Details
Details
- Reviewers
ngraham - Group Reviewers
Frameworks KNewStuff - Commits
- R304:197f257cb9b6: Ensure the dialog title is correct with an uninitialised engine
Diff Detail
Diff Detail
- Repository
- R304 KNewStuff
- Branch
- ensure-dialog-title-with-uninitialised-engine (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 19672 Build 19690: arc lint + arc unit
src/qtquick/qml/Dialog.qml | ||
---|---|---|
55 | For readability's sake and to avoid nested i18n() calls which would cause string puzzles, I would do it like this: title: component.downloadNewWhat.length === 0 ? i18n("Download new stuff"): i18n("Download New %1," component.downloadNewWhat) also "stuff" lol |
src/qtquick/qml/Dialog.qml | ||
---|---|---|
55 | Quite right, also just simpler code in general :) Stuff indeed ;) |