Differential D25861

[Notifications] Fix crash accessing ViewTransition attached property
ClosedPublic
Actions

Authored by broulik on Dec 10 2019, 5:35 PM.

Details

Reviewers
ngraham
davidedmundson
Group Reviewers
Plasma
Commits
R120:34ca49210ff4: [Notifications] Fix crash accessing ViewTransition attached property
Summary

There's something really funky going on in this...
Avoid using ViewTransition attached property be just setting the animation target before triggering the model removal.

BUG: 414066

Test Plan
  • Remains to be seen whether the crash is gone but gdb showed it was related to QQuickViewTransitionAttached which we no longer use
  • Hasn't crashed for a while lol

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Dec 10 2019, 5:35 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 10 2019, 5:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 10 2019, 5:35 PM
broulik updated this revision to Diff 71219.
  • remove leftover debugging
davidedmundson accepted this revision.Dec 10 2019, 5:59 PM
This revision is now accepted and ready to land.Dec 10 2019, 5:59 PM
ngraham added a comment.Dec 10 2019, 8:29 PM

No more crashes so far. :)

Closed by commit R120:34ca49210ff4: [Notifications] Fix crash accessing ViewTransition attached property (authored by broulik). · Explain WhyDec 10 2019, 8:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 71225

View Options

applets/notifications/package/contents/ui/FullRepresentation.qml

Loading...