Differential D25841

[Cuttlefish] Set context properties before loading file
ClosedPublic
Actions

Authored by davidre on Dec 10 2019, 12:25 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R118:e56bc283019f: [Cuttlefish] Set context properties before loading file
Summary

Otherwise we load the file and the context properties are still undefined
leading to a buch ReferenceErrors because they are undefined.

Test Plan

Still works - less warnings

Diff Detail

Repository
R118 Plasma SDK
Branch
contextprops (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19645
Build 19663: arc lint + arc unit
davidre created this revision.Dec 10 2019, 12:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 10 2019, 12:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidre requested review of this revision.Dec 10 2019, 12:25 PM
davidre updated this revision to Diff 71180.Dec 10 2019, 12:27 PM

codestyle++

ngraham accepted this revision.Dec 10 2019, 2:03 PM
This revision is now accepted and ready to land.Dec 10 2019, 2:03 PM
Closed by commit R118:e56bc283019f: [Cuttlefish] Set context properties before loading file (authored by davidre). · Explain WhyDec 10 2019, 2:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcuttlefish/src/main.cpp (9 lines)

Diff 71180

View Options

cuttlefish/src/main.cpp

Loading...