Differential D25591

support for the shadow and effectiveBackgroundhints
ClosedPublic
Actions

Authored by mart on Nov 28 2019, 1:53 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:84247e8424b7: support for the shadow and effectiveBackgroundhints
R120:8aae84a2302f: support for the shadow and effectiveBackgroundhints
Summary

support the automatic shadow hint

When the hint is shadowedBackground, do an automatic shadow with a shader, and
change applet's color to complementary

Test Plan

Tested the functionality on various applets. To test, the digital clock is enabling explicitly background configurability

Diff Detail

Repository
R120 Plasma Workspace
Branch
mart/effectiveBackgroundHints
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19255
Build 19273: arc lint + arc unit
mart created this revision.Nov 28 2019, 1:53 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 28 2019, 1:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Nov 28 2019, 1:53 PM
mart added a reviewer: Plasma.Nov 28 2019, 1:53 PM
davidedmundson accepted this revision.Nov 28 2019, 2:52 PM
This revision is now accepted and ready to land.Nov 28 2019, 2:52 PM
mart updated this revision to Diff 70515.Nov 28 2019, 5:13 PM
  • adapt to api changes
mart edited the test plan for this revision. (Show Details)Nov 28 2019, 5:14 PM
Closed by commit R120:84247e8424b7: support for the shadow and effectiveBackgroundhints (authored by mart). · Explain WhyNov 29 2019, 9:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 70515

View Options

applets/digital-clock/package/contents/ui/main.qml

Loading...
View Options

components/containmentlayoutmanager/qml/BasicAppletContainer.qml

Loading...