Have the wallpaper combo managed by KConfigDialogManager
ClosedPublic
Actions

Authored by ervin on Nov 15 2019, 10:34 AM.

Details

Reviewers

Group Reviewers

Plasma

Commits

Summary

We use an intermediate property which maps to an index since it's
exactly what KConfigDialogManager expects with a QComboBox.

Also relayouted a bit the ctor and the file to make it easier to
understand (several aspect were weaved together).

Repository

R133 KScreenLocker

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 19218
Build 19236: arc lint + arc unit

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

ervin requested review of this revision.Nov 15 2019, 10:34 AM

On some condition the assert would be triggered

This revision is now accepted and ready to land.Nov 28 2019, 9:29 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			CMakeLists.txt (1 line)
M			greeter/greeterapp.cpp (2 lines)
M			kcfg/kscreenlockersettings.kcfg (2 lines)
M			kcm/kcm.h (3 lines)
M			kcm/kcm.cpp (100 lines)
M			kcm/kcm.ui (4 lines)
M			kscreensaversettings.h (14 lines)
M			kscreensaversettings.cpp (48 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	69791	6b9f658		Nov 15 2019, 10:34 AM	★	★
Diff 2	70430	2298ac3	On some condition the assert would be triggered	Nov 27 2019, 3:00 PM	★	★
Diff 3	70485	e5e8c91	R133:27d907610381c9c9d952f40d518322315830fdc7	Nov 28 2019, 9:26 AM	★	★