Differential D25435

[Network Ioslave] Add Display name to network:/
ClosedPublic
Actions

Authored by meven on Nov 21 2019, 10:08 AM.

Details

Reviewers
ngraham
Group Reviewers
Frameworks
Commits
R320:2f6f67aba31b: [Network Ioslave] Add Display name to network:/
Summary

CCBUG: 414345

Diff Detail

Repository
R320 KIO Extras
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19016
Build 19034: arc lint + arc unit
meven created this revision.Nov 21 2019, 10:08 AM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptNov 21 2019, 10:08 AM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Nov 21 2019, 10:08 AM
meven updated this revision to Diff 70092.Nov 21 2019, 10:14 AM

Formatting

broulik added a subscriber: broulik.Nov 21 2019, 10:35 AM

I think this needs a add_definitions(-DTRANSLATION_DOMAIN and Messages.sh file?

meven updated this revision to Diff 70094.Nov 21 2019, 10:42 AM

Add translation and Messages.sh to network:/

meven added a comment.Nov 21 2019, 10:46 AM
In D25435#565544, @broulik wrote:

I think this needs a add_definitions(-DTRANSLATION_DOMAIN and Messages.sh file?

Thanks done

ngraham added a comment.Nov 21 2019, 2:08 PM

Hmm, somehow this does not work for me. The "Network" place in the places panel still shows "." as the text.

ngraham added a comment.Nov 21 2019, 2:10 PM

Ah, I see why: because the bug report is about remote:/, not network:/. I guess network needs this patch too, but it's not fully complete unless remote:/` gets the same fix.

meven added a comment.Nov 21 2019, 2:11 PM
In D25435#565600, @ngraham wrote:

Ah, I see why: because the bug report is about remote:/, not network:/. I guess network needs this patch too, but it's not fully complete unless remote:/` gets the same fix.

That's why I opened D25436 to fix the other ioslave as well.

ngraham accepted this revision.Nov 21 2019, 2:16 PM

Ah, perfect.

This revision is now accepted and ready to land.Nov 21 2019, 2:16 PM
Closed by commit R320:2f6f67aba31b: [Network Ioslave] Add Display name to network:/ (authored by meven). · Explain WhyNov 21 2019, 2:40 PM
This revision was automatically updated to reflect the committed changes.
ltoscano added a subscriber: ltoscano.Nov 22 2019, 8:43 AM
ltoscano added inline comments.
network/Messages.sh
3

This does not work as it is, because it does not look into the subdirectories. Hint for testing:
https://tsdgeos.blogspot.com/2010/08/how-to-run-messagessh-file-to-create.html

I'm going to fix it (replace *.cpp with $(find . -name '*.cpp') )

meven added inline comments.Nov 22 2019, 9:30 AM
network/Messages.sh
3

Thanks I may the wrong assumption $XGETTEXT was recursive.

Revision Contents
Changeset List

Diff 70094

View Options

network/Messages.sh

Loading...
View Options

network/ioslave/CMakeLists.txt

Loading...
View Options

network/ioslave/networkslave.cpp

Loading...
View Options

network/network/CMakeLists.txt

Loading...