Differential D25219

Only create a session config when actually restoring a session
ClosedPublic
Actions

Authored by ngraham on Nov 8 2019, 4:21 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Frameworks
Commits
R237:23d4f14601fd: Only create a session config when actually restoring a session
Summary

This allows manually invoking session restoration logic without creating duplicate
configs, in support of D25106 and https://invent.kde.org/kde/okular/merge_requests/58/

Test Plan

Apply either of the above patches and verify that it works

Diff Detail

Repository
R237 KConfig
Branch
session-config (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18985
Build 19003: arc lint + arc unit
ngraham created this revision.Nov 8 2019, 4:21 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 8 2019, 4:21 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Nov 8 2019, 4:21 PM
ngraham retitled this revision from Also only create a session config when actually restoring a session to Only create a session config when actually restoring a session.Nov 8 2019, 4:23 PM
ngraham mentioned this in D25106: Also allow invoking session restoration logic when apps are manually launched.
ngraham added a dependent revision: D11382: Add an option to show tabs from last time when Dolphin starts.
ngraham added a comment.Nov 19 2019, 6:30 PM

Can I get a review on this?

anthonyfieroni added a subscriber: anthonyfieroni.Nov 19 2019, 7:31 PM
anthonyfieroni added inline comments.
src/gui/kconfiggui.cpp
73–77

sessionConfig() can be nullptr can you add a check.

ngraham updated this revision to Diff 70054.Nov 20 2019, 2:16 PM
ngraham marked an inline comment as done.

Check for sessionConfig() being nullptr

davidedmundson accepted this revision.Nov 26 2019, 10:21 AM
This revision is now accepted and ready to land.Nov 26 2019, 10:21 AM
Closed by commit R237:23d4f14601fd: Only create a session config when actually restoring a session (authored by ngraham). · Explain WhyNov 26 2019, 2:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/gui/kconfiggui.cpp (8 lines)

Diff 70054

View Options

src/gui/kconfiggui.cpp

Loading...