This adds an isLoading property to KNSQuick::Engine, and that is used
to show a busy indicator (with descriptive label) when engine is loading.
BUG:413439
ngraham |
KNewStuff | |
Frameworks | |
VDG |
This adds an isLoading property to KNSQuick::Engine, and that is used
to show a busy indicator (with descriptive label) when engine is loading.
BUG:413439
Without this patch: Empty content panel while loading is happening
With this patch:
No Linters Available |
No Unit Test Coverage |
Buildable 18570 | |
Build 18588: arc lint + arc unit |
Now you don't need those PassiveNotifications anymore, because otherwise you wind up with duplicate messages:
I still see "Loading Data" in a passiveNotification as well as in text under the loading indicator. Do we really need the passiveNotifications at all? I think we can probably improve the user experience vy removing them entirely. For example instead of "Loading one preview" we can just show individual loading indicators on the previews themselves
i'm seeing a couple of bits which really probably want to be turned into something else (but as separate diffs, as i'm not really keen on this ending up yet another several-months-long saga - on which note, see D25197):
Do we really need the passiveNotifications at all? I think we can probably improve the user experience vy removing them entirely. For example instead of "Loading one preview" we can just show individual loading indicators on the previews themselves
i'm afraid we do - as you might gather from that short list above, there's an enormous amount of of these bits of information being thrown back from the engine, and until we're certain we have captured all of them by some other method (and removed the noise), we really can't just get rid of it. (yes, i realise how much you dislike[1] them, and i'm quite happy to move towards removing them, we just can't do it by just straight up removing them entirely. We also can't simply replace it with a dialog box either, because /some/ are informational and can be safely ignored, while some are important, and there's no straightforward way to tell which is which)
[1] was going to say hate, but it's a terribly strong term, and i feel like we probably need to reserve it for things which actually deserve that strength ;)