Fix PageRow globalToolBar documentation
ClosedPublic

Authored by dkardarakos on Nov 1 2019, 12:37 PM.

Details

Summary

In PageRow documentation, globalToolBar's style contains an unordered list of the various style value options. With this commit, the list is properly displayed.

Diff Detail

Repository
R169 Kirigami
Branch
fix-pagerow-doc (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18441
Build 18459: arc lint + arc unit
dkardarakos created this revision.Nov 1 2019, 12:37 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptNov 1 2019, 12:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
dkardarakos requested review of this revision.Nov 1 2019, 12:37 PM
ognarb accepted this revision.Nov 1 2019, 3:27 PM
ognarb added a subscriber: ognarb.

LGTM

This revision is now accepted and ready to land.Nov 1 2019, 3:27 PM

Can you also have a look at the height and reservedSpace properties below it? Those have similar issues.

dkardarakos updated this revision to Diff 69185.Nov 2 2019, 9:27 AM

Fix globalToolBar documentation

Ensure that the documentation of each property of the globalToolBar group property is presented correctly

ahiemstra accepted this revision.Nov 2 2019, 3:13 PM

Great, thank you!

This revision was automatically updated to reflect the committed changes.

Great, thank you!

It was nothing!