Replace KHotkeys with KGlobalAccel
Details
Details
- Reviewers
davidedmundson mlaurent - Group Reviewers
Plasma - Maniphest Tasks
- T2050: sunsetting KHotKeys
- Commits
- R103:507bc58bf3e8: Port to KGlobalAccel
Diff Detail
Diff Detail
- Repository
- R103 KMenu Editor
- Branch
- globalaccel (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 18389 Build 18407: arc lint + arc unit
Comment Actions
Concept ++++
We don't need WITH_GLOBALACCEL guards. It's a dep of kxmlgui which we link against anyway.
CMakeLists.txt | ||
---|---|---|
39 | Why removing it ? |
CMakeLists.txt | ||
---|---|---|
39 | Accidentally |
basictab.cpp | ||
---|---|---|
38 | still necessary to #ifndef ? |
Comment Actions
Shortcut setting and displaying works so far in my testing.
I still need to do the migration of existing shortcuts otherwise if user had set a shortcut though kmenuedit before it wouldn't be displayed in kmenuedit (although it would be functional).